-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WFLY-2651 If there is a transaction active when the setup action first r... #5677
Conversation
Build 2153 is now running using a merge of bafd08d |
Build 2153 outcome was FAILURE using a merge of bafd08d Build problems:Failed tests detected
Failed tests
|
try { | ||
final TransactionManager tm = transactionManager.getOptionalValue(); | ||
if (tm != null) { | ||
holder.actuallyCleanUp = isTransactionActive(tm, tm.getStatus()); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So you want to clean up if the tx exists when setup() was first called, but not if it's opened later? I believe that's what will happen here and it sounds different from what the comment at L103 says.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
oops.
I wonder why this seemed to fix the issue then. I will fix this up.
…t runs don't attempt to close it
Build 2188 is now running using a merge of d7907b4 |
Build 2188 outcome was SUCCESS using a merge of d7907b4 |
Merged. |
Is this fix going to be present on any JBoss EAP release? |
@velo there was no bug reported for this in EAP, and as such it was not backported. We don't automatically back port everything as fixes are not always applicable. |
...uns don't attempt to close it